Repository navigation
fix(workspace): the status bar does not keep 'Running query…' after a failed run - #1435
Merged
Merged
Conversation
… failed run endBusy kept the message beginBusy had set, so a failed query (and every explain) left 'Running query…' / 'Explaining query…' in the status bar, next to the row counts of the previous result. A busy message now goes away with the busy state, and failures report 'Query failed' / 'Query timed out' / 'Statement n of m failed' / 'Explain failed' without the stale counts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while driving a build of `dev`.
Problem
`QueryaShellStatus.endBusy` kept the message `beginBusy` had set, so a failed query (and every Explain) left Running query… / Explaining query… in the status bar, next to the row / column counts of the previous result.
Change
Tests
`test/core/ui/querya_shell_status_test.dart`: busy message cleared, failure replaces it and drops old counts, `endBusy` after a failure keeps the failure message, a result message survives `endBusy`.
Not run locally; CI is the check.